-
Notifications
You must be signed in to change notification settings - Fork 118
[TRG 7.07 + 10.02] feat: added that the eclipse foundation contributors need to be included in KITs notice. #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@AngelikaWittek is this something that must be included? Because the KITs all include in their notice section the Eclipse Foundation Contributors, and we have a case for a new KIT that does not included that, and now we need to decide if we enforce it as a project, or not: |
lgblaumeiser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I do not see a need for this change, because everything is already in place. I would recommend, before starting such activities to come back to me and check the requirement! If you insist on changes, I propose a small section in 10.02 pointing to 7.07 and we can argue, that in the right section a MUST would help to express the urgency.
|
|
||
| ::: | ||
|
|
||
| The copyright for the Eclipse Foundation Contributors `202x Contributors to the Eclipse Foundation` (with the respective year(s)) **MUST** be included in all markdown NOTICE copyright. For more information consult [Eclipse Foundation Rulebook - Legal Documentation](https://www.eclipse.org/projects/handbook/#legaldoc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already stated in 29-32, so this statement is redundant. We could agree on the MUST which is missing above, but please add it there
| - SPDX-License-Identifier: CC-BY-4.0 | ||
| - SPDX-FileCopyrightText: 202x {Owner} | ||
| - SPDX-FileCopyrightText: 202x Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not the preferred way, it should be a clear statement of who the copyright owner is. Actually, this formulation is misleading, who is the contributor, typically a person, who is the owner of the ip contributed by this person, typically the employer of that person, so this change is wrong!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the eclipse project handbook we have written that it is not the person but the company which is doing the contribution: https://www.eclipse.org/projects/handbook/#ip-copyright-headers, until now the eclipse foundation asked us to add this line SPDX-FileCopyrightText: 202x Contributors to the Eclipse Foundation in our kits.
Therefore I am investigating the real need for it, and starting a discussion if we need to enforce that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Handbook is pretty unclear at this point. If you read the section on what a contributor is, it is stated, that it is basically the person doing the contribution, as it is also the person, who signs the ECA, if there is no company ECA signed (last thing I added). In this case, the copyright owner and the contributor are simply not the same entity. I would suggest that we clarify this with the foundation, as I think, that part is not so clear as it could be. Still, the phrase should be the last resort like the "and others" part in the handbook section you mentioned. Let us phrase the question to the EF together, so that we get the answer we want.
| - SPDX-FileCopyrightText: 2023, 2025 Mercedes Benz Group | ||
| - SPDX-FileCopyrightText: 2023, 2025 BASF SE | ||
| - SPDX-FileCopyrightText: 2023, 2025 Schaeffler AG | ||
| - SPDX-FileCopyrightText: 2023, 2025 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave this example out!
| - SPDX-License-Identifier: CC-BY-4.0 | ||
| - SPDX-FileCopyrightText: 2025 <Your Company FullName> | ||
| - SPDX-FileCopyrightText: 2025 Bayerische Motoren Werke Aktiengesellschaft (BMW AG) | ||
| - SPDX-FileCopyrightText: 2025 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - SPDX-FileCopyrightText: 2025 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we now need to remove the contributor to the eclipse foundation? Look at all the KITs we are including it in every single one. If we don't harmonize it there is just more confusion if we start now creating without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should not encourage using that, as it is a nice workaround but not the proper way. If, e.g., I use it, I actually am on legal uncertain ground, as I wrote. I am the contributor but the owner of the ip I contribute is owned by Cofinity-X GmbH. You could argue, that the term can be interpreted as Cofinity-X GmbH is the contributor and I am the willingless tool that executes that, but in general it is not clear and in the wrong interpretation, I violate my employees contract in stating that.
It is also awful for the maintainer of the project, because the close says nothing about the ownership. The message is, that the contributor does not care about the contributed ip and does not want to be bugged again with it. Unfortunately, there are situations, where the consent of all ip owners is needed, but if this is not expressed properly, it is very hard to find out, who the owner of the stuff is.
So, best practice is, that you should use a clear ownership declaration, like (c) 2025 Cofinity-X GmbH, because then, ownership is clear and Cofinity-X can be asked regarding legal aspects, if the need arises.
That is, why we should not encourage the usage of it by providing it in examples. It is a last resort, which I admit also use in certain situations, but it is typically in situations, where we tak about a very small amount of changes, the original author of a whole KIT view should reflect the ownership of the expressed ip by the name of the owner. Period.
|
|
||
| ## Copyright Notice | ||
|
|
||
| Mandatory for every KIT, it **MUST** be included in every file (not just on the adoption view!). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I would assume, that TRG 7.07 is enough, this section is redundant, I would reduce it, if you want to reference that copyright notices have to be done according to 7.07.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is done already in another section before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Than, this setion is superfluous, it does not add anything, not describe in 7.07 and only adds redundancy.
That is what I am doing @lgblaumeiser, and specially I want to understand the origin of the requirement again from the Eclipse Foundation side from @AngelikaWittek. |
|
Thanks for the review. Let's look that together in the Eclipse Tractus-X Committer meeting. |
Description
There were no clear indications that in the NOTICE sections the Eclipse Foundation contributions must be mentioned.
As mentioned here: https://eclipse-tractusx.github.io/documentation/kit-framework#copyright-notice
Up to discussion (To clarify with Committers and eclipse foundation @AngelikaWittek).
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: